[fp-enhancer] Improve pkg/actionpins: eliminate mutable shortSHA variable#30808
Merged
[fp-enhancer] Improve pkg/actionpins: eliminate mutable shortSHA variable#30808
Conversation
…ariable Replace the two-step mutable initialization of shortSHA with a single immutable declaration using Go's built-in min function. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors countPinKeyMismatches in pkg/actionpins to compute a shortened SHA without using a mutable local variable, relying on Go’s built-in min to slice to at most 8 characters.
Changes:
- Replaces a conditional reassignment of
shortSHAwith a single immutable slice expression. - Keeps the warning log output behavior equivalent while simplifying the code path.
Show a summary per file
| File | Description |
|---|---|
pkg/actionpins/actionpins.go |
Makes shortSHA initialization immutable by slicing to min(len(pin.SHA), 8) before logging key/version mismatch warnings. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 1.6M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies a tasteful immutability improvement to
pkg/actionpinsas part of a round-robin functional-programming enhancement pass.Change
In
countPinKeyMismatches, theshortSHAvariable was declared mutable and conditionally reassigned:Replaced with a single immutable declaration using Go's built-in
minfunction (available since Go 1.21):Benefits
Round-Robin Progress
pkg/actionpins(first package in cycle)pkg/agentdrainValidation
make buildpassesmake fmtpassesTestCountPinKeyMismatches_ReturnsOnlyVersionMismatchespassesReferences: §25489567849